Merge lp://staging/~costales/unav/0.60-nik90-part-1 into lp://staging/unav

Proposed by costales
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 77
Merged at revision: 67
Proposed branch: lp://staging/~costales/unav/0.60-nik90-part-1
Merge into: lp://staging/unav
Prerequisite: lp://staging/~nik90/unav/unav-convergence-part-1
Diff against target: 9424 lines (+5/-9404)
2 files modified
nav/libraries/jquery.min.js (+4/-9404)
qml/PoiListPage.qml (+1/-0)
To merge this branch: bzr merge lp://staging/~costales/unav/0.60-nik90-part-1
Reviewer Review Type Date Requested Status
Nekhelesh Ramananthan Approve
Review via email: mp+293465@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-04-30.

Commit message

Agreed. Changed branch destination

Description of the change

Minor fixes:
- Less size for jquery
- Issue: Click fav > Search nearby of that fav > Click show all in map: Issue, popup is not hidden.

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote : Posted in a previous version of this proposal

I don't think "less size for jquery" is related to convergence and should be part of a new branch. My branch lp:~nik90/unav/unav-convergence-part-1 is in itself a big branch with invasive code changes. Let's only make changes related to convergence in it.

review: Needs Fixing
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches