uNav

Merge lp://staging/~costales/unav/0.59-new_fixes into lp://staging/unav

0.59-new_fixes
Merge into trunk

Proposed by costales on 2016-04-20

Status:

Merged

Merged at revision:

Proposed branch:

lp://staging/~costales/unav/0.59-new_fixes

Merge into:

lp://staging/unav

Diff against target:

366 lines (+44/-87)

8 files modified

app-armor.json (+0/-1)
nav/class/UI.js (+1/-1)
nav/index.html (+2/-20)
qml/Coordinate.qml (+4/-8)
qml/Favorites.qml (+4/-2)
qml/Location.qml (+6/-2)
qml/Main.qml (+23/-51)
qml/PoiListPage.qml (+4/-2)

To merge this branch:

bzr merge lp://staging/~costales/unav/0.59-new_fixes

Related bugs:

Bug #1569947: Misleading AGPS warning

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Nekhelesh Ramananthan		2016-04-20	Approve on 2016-04-22
Review via email: mp+292422@code.staging.launchpad.net

Description of the change

- Fixed dark purple in navigation panel.
- Fixed: Set a route. Search > Click on any Location entry = Bug: Center button is disabled.
- Fixed: open uNav > Click on map (you will see one popup) > click on a favorite or search > bug: popup will be the previous.
- Fixed: open uNav > Set route > Click on map (you'll see the popup) > click on current pos, destination or origin > Bug: popup will not update the text.

lp://staging/~costales/unav/0.59-new_fixes updated on 2016-04-20

59. By costales on 2016-04-20: Bug: Popup not updated
60. By costales on 2016-04-20: Revert testing code commented

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2016-04-20:

Please update screenshot in welcome wizard of the navigation panel where you changed orange to blue.

review: Needs Fixing

lp://staging/~costales/unav/0.59-new_fixes updated on 2016-04-22

61. By costales on 2016-04-22: Window size for convergence in tablet
62. By costales on 2016-04-22: Restored orange in indication (blue is soft and in so many places
63. By costales on 2016-04-22: Window size for convergence in tablet
64. By costales on 2016-04-22: Removed AGPS popup
65. By costales on 2016-04-22: Fixed click on pos, destination, origin with popup
66. By costales on 2016-04-22: Updated testing code

Revision history for this message

costales (costales) wrote on 2016-04-22:

@Nekhelesh: Restored to orange again. The blue is so light and it's a so blue in the UI. Not nice. The orange is the blue's complementary, then good color.

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2016-04-22:

I didnt find any regressions. Looks good to me. I am not fully sure about the AGPS dialog removal. But I don't much about the location services to comment on that. With that I am approving this MP.

review: Approve