uNav

nav/img/header/center_onpos.svg (+0/-167)
nav/img/header/center_onpos_light.svg (+0/-167)
nav/img/header/destination.svg (+0/-255)
nav/img/header/gps_off.svg (+0/-161)
nav/img/header/nav-actions-transparent.svg (+195/-0)
nav/img/header/nav-actions.svg (+195/-0)
nav/img/header/transparent_center_onpos.svg (+0/-167)
nav/img/header/transparent_center_onpos_light.svg (+0/-167)
nav/img/header/transparent_destination.svg (+0/-255)
nav/img/header/transparent_gps_off.svg (+0/-168)
nav/index.html (+8/-1)
nav/locales/unav.pot (+52/-54)
qml/Main.qml (+8/-8)
qml/js/PoiCategories.js (+2/-2)

To merge this branch:

bzr merge lp://staging/~costales/unav/0.59-general-fixes

Related bugs:

Bug #1570343: Locate me icon is confusing to new users	High	Fix Released
Bug #1571596: [Regression] Route status not set correctly when simulating a route	Critical	Fix Released
Bug #1571608: Use full names for POI categories	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Nekhelesh Ramananthan		2016-04-18	Approve on 2016-04-19
Review via email: mp+292185@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-04-18.

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2016-04-18:

Icons are missing in the POI Page for those POI Category names that you changed. The POI category icon is defined as,

source: Qt.resolvedUrl("../nav/img/poi/" + model.en_label + ".svg")

As you can see, it depends on the model.en_label

So to fix it, you will have to name the icons with the same en_label to ensure all icons are visible.

B&B.svg => Bed & Breakfast.svg
Convenience.svg => Convenience Store.svg

And so on ... .

review: Needs Fixing

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2016-04-18:

The so called route icon which is shown when simulation/navigating a route is missing when the page header is hidden.

review: Needs Fixing

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2016-04-18:

1629 - Component.onCompleted: {
1630 - mainPageStack.executeJavaScript("qml_set_route_status();")
1631 - }

The above lines being removed has led to the user position being unknown when looking for nearby POI in the destination.

Steps to reproduce bug:
1. Navigate a route from current location to Point B
2. Open the route menu and click on NearBy Destination
3. Notice that it now says "Unknown current position".

mainPageStack.executeJavaScript("qml_set_route_status();") was used to set the current user position.

review: Needs Fixing

lp://staging/~costales/unav/0.59-general-fixes updated on 2016-04-18

79. By costales on 2016-04-18: Restored qml_set_route_status for Nearby

Revision history for this message

Nekhelesh Ramananthan (nik90) wrote on 2016-04-18:

Out of the 3 issues listed above, i have fixed 2 of those issues (icon related) at lp:~nik90/unav/marcos-general-fixes. Feel free to merge them to your branch to save time and effort.

lp://staging/~costales/unav/0.59-general-fixes updated on 2016-04-18

80. By costales on 2016-04-18: Revert POI names and fixed just 2
81. By costales on 2016-04-18: Show other-actions in fullscreen

Revision history for this message

costales (costales) wrote on 2016-04-18:

Fixed.
About icons I saw an undesire behavior, any used icon will be in the history with the older name. Then I think will be better to fix the minimal icons possible.

lp://staging/~costales/unav/0.59-general-fixes updated on 2016-04-18