ssh-import-id

Merge lp://staging/~cosmos-door/ssh-import-id/fix-1565275 into lp://staging/ssh-import-id

  1. fix-1565275
  2. Merge into trunk
Proposed by Mitsuya Shibata
Status: Merged
Merged at revision: 210
Proposed branch: lp://staging/~cosmos-door/ssh-import-id/fix-1565275
Merge into: lp://staging/ssh-import-id
Diff against target: 20 lines (+2/-1)
1 file modified
ssh_import_id/__init__.py (+2/-1)
To merge this branch: bzr merge lp://staging/~cosmos-door/ssh-import-id/fix-1565275
Reviewer Review Type Date Requested Status
Scott Moser Approve
Mitsuya Shibata (community) Needs Resubmitting
Review via email: mp+290796@code.staging.launchpad.net

Description of the change

  * ssh_import_id/__init__.py:
    - add support to import multiple keys

To post a comment you must log in.
Revision history for this message
Mitsuya Shibata (cosmos-door) wrote :

Note: Perhaps fetch_keys_lp() doesn't need to modify.

Revision history for this message
Scott Moser (smoser) wrote :

you're right, fetch_keys_lp does not need modification.
Please remove that change.
Feel free to test with my ssh keys (gh:smoser or lp:smoser) as I have multiple in both places.

I'd +1 the rest of the change though.

review: Needs Fixing
lp://staging/~cosmos-door/ssh-import-id/fix-1565275 updated
211. By Mitsuya Shibata

  * ssh_import_id/__init__.py:
    - remove unneeded modification for launchpad from previous commit.

Revision history for this message
Mitsuya Shibata (cosmos-door) wrote :

Thank you for review! I pushed commit to remove unneeded changes.

review: Needs Resubmitting
Revision history for this message
Andrew Starr-Bochicchio (andrewsomething) wrote :

Looks like the comment was addressed. Anything else holding this up? Love to see this SRUed in Ubuntu.

Revision history for this message
Mitsuya Shibata (cosmos-door) wrote :

I'm waiting to be merged...
Should I ping to developer or any ML?

Revision history for this message
Scott Moser (smoser) :
review: Approve
Revision history for this message
Mitsuya Shibata (cosmos-door) wrote :

Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches