OpenStack Charm Testing

Merge lp://staging/~corey.bryant/openstack-charm-testing/ocata-client-updates into lp://staging/openstack-charm-testing

ocata-client-updates
Merge into trunk

Proposed by Corey Bryant on 2017-02-27

Status:	Merged
Merged at revision:	282
Proposed branch:	lp://staging/~corey.bryant/openstack-charm-testing/ocata-client-updates
Merge into:	lp://staging/openstack-charm-testing
Diff against target:	79 lines (+32/-11) 2 files modified bin/post-deploy-config (+16/-6) bin/quantum-ext-net (+16/-5)
To merge this branch:	bzr merge lp://staging/~corey.bryant/openstack-charm-testing/ocata-client-updates
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ryan Beisner		2017-02-27	Approve on 2017-02-28
Review via email: mp+318402@code.staging.launchpad.net

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2017-02-28:

Not-a-blocker, but: It seems like we should only import novaclient only one time. I believe the usage of no_client could be switched to novaclient.client.

Can you see what that looks like?

review: Needs Information

Revision history for this message

Ryan Beisner (1chb1n) wrote on 2017-02-28:

Per irc discussion, proceeding as-proposed because replacing no_client with something like someclient.vX.client.Client(args, more_args) isn't desired.

review: Approve