Postorius

Merge lp://staging/~coolyashish/postorius/add_email_address_in_settings into lp://staging/postorius

  1. add_email_address_in_settings
  2. Merge into trunk
Proposed by Ashish
Status: Rejected
Rejected by: Terri
Proposed branch: lp://staging/~coolyashish/postorius/add_email_address_in_settings
Merge into: lp://staging/postorius
Diff against target: 10 lines (+1/-1)
1 file modified
src/postorius/models.py (+1/-1)
To merge this branch: bzr merge lp://staging/~coolyashish/postorius/add_email_address_in_settings
Reviewer Review Type Date Requested Status
Terri Pending
Review via email: mp+252939@code.staging.launchpad.net

Description of the change

Previously we are getting error on add email address page in user's settings as there is not email_confirmation_from set in the send_confirmation_link function in AddressConfirmationProfile model. This change adds the required email in the function.

To post a comment you must log in.
Revision history for this message
Abhilash Raj (raj-abhilash1) wrote :

We don't want to send confirmation email from the user's email, it should be from listowner or some other address (like noreply@domain or something).

Revision history for this message
Terri (terriko) wrote :

Abhilash has a more complete fix here https://code.launchpad.net/~raj-abhilash1/postorius/lp1437866

Unmerged revisions

206. By Ashish

EMAIL_CONFIRMATION_FROM in AddressConfirmationProfile.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches