lp://staging/~compiz-team/compiz/compiz.fix_1159324

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/compiz/0.9.9 at revision 3636

PS Jenkins bot (community): Approve (continuous-integration) on 2013-03-25

MC Return: Approve on 2013-03-24

Compiz Maintainers: Pending requested 2013-03-24

Diff: 476 lines (+312/-93)

4 files modified

plugins/place/src/constrain-to-workarea/include/constrain-to-workarea.h (+6/-0)
plugins/place/src/constrain-to-workarea/src/constrain-to-workarea.cpp (+62/-5)
plugins/place/src/constrain-to-workarea/tests/constrain-to-workarea/src/test-place-constrain-to-workarea.cpp (+235/-58)
plugins/place/src/place.cpp (+9/-30)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1159324: [regression-r3635] Guake window appears placed by offset non-existent decoration

High

Fix Released

Link a bug report

Related blueprints

3636. By Sam Spilsbury on 2013-03-24

Don't offset placement by window extents for windows that have a static
gravity.

Those windows want to be placed as though they didn't have decorations.

Get cp::constrainPositionToWorkArea under test and clean up the other
place tests too, so that they only test one thing at a time.

(LP: #1159324)

3635. By Sam Spilsbury on 2013-03-23

Also decorate shadow-only windows. Strangely this fixes (LP: #1158161).

Refactor DecorWindow::update too and split up that function into separate bits. Fixes: https://bugs.launchpad.net/bugs/1158161.

Approved by PS Jenkins bot, Łukasz Zemczak, MC Return, Alfred Neumayer.

3634. By Sam Spilsbury on 2013-03-22

Use the actual change in window size to determine if we need to change
  the frame window size, don't just use the difference in frame extents
  to determine that.

  (LP: #1140505). Fixes: https://bugs.launchpad.net/bugs/1140505.

Approved by PS Jenkins bot, Sam Spilsbury.

3633. By Sam Spilsbury on 2013-03-13

Don't set lastFrameExtents unless the window geometry actually changed - as
that variable only exists to track changes in the actual geometry of
the window and not the apparant frame extents.

Added tests to verify that behaviour.

(LP: #1138517). Fixes: https://bugs.launchpad.net/bugs/1138517.

Approved by PS Jenkins bot, Timo Jyrinki.

3632. By Sam Spilsbury <email address hidden> on 2013-03-08

Added the plug-in "Freely Transformable Windows" aka freewins converted from git to bzr (including full history) to lp:compiz.

(LP: #1012194). Fixes: https://bugs.launchpad.net/bugs/1012194.

Approved by PS Jenkins bot, Sam Spilsbury.

3631. By Brandon Schaefer on 2013-03-08

Instead of not grabbing all the keys when IgnoreTap is set, add a patch to only not grab Super+P. Allowing part of this bug to say fix (LP:950160), while fixing bugs such as this (LP:1075207). This is only a patch for unity, otherwise it will not cause any problems with trunk compiz. Fixes: https://bugs.launchpad.net/bugs/1075207.

Approved by Andrea Azzarone, Sam Spilsbury, PS Jenkins bot.

3630. By MC Return on 2013-03-04

Grid plugin:

Fixed wrong calculation of top-left corner coordinates.
Now detection of this corner also works correctly on multimonitor configurations.
Improved readability of the grid corner detection code.

(LP: #1139835). Fixes: https://bugs.launchpad.net/bugs/1139835.

Approved by PS Jenkins bot, Łukasz Zemczak.

3629. By PS Jenkins bot on 2013-02-28

Releasing 1:0.9.9~daily13.02.28-0ubuntu1 to ubuntu.

Approved by PS Jenkins bot.

3628. By MC Return on 2013-02-28

Fixed minor cppcheck issues:

Do not assign a value to rv, because this value is never used.
Instead declare and assign a value to bool rv in the same line.

Do not assign false to Bool readonly, because this value is never used.
Instead declare the variable and assign a value in the same line.

Other minor problems:

Fixed some guaruntee->guarantee typos in comments.
Fixed copyright headers still referring to the old .c files.
Fixed wrong names in copyright headers.

(LP: #1134251). Fixes: https://bugs.launchpad.net/bugs/1134251.

Approved by Sam Spilsbury.

3627. By MC Return on 2013-02-27

Firepaint:

Inverted the statements in the if conditions checking cache_size
to improve readability and to harmonize the code with showmouse.
Fixed minor coding style issues (added spaces).

Firepaint and Showmouse:

Added constants replacing magic numbers to improve readability.
Removed redundant newlines.

Approved by Brandon Schaefer, Sam Spilsbury.