Compiz

Merge lp://staging/~compiz-team/compiz/compiz.fix_1016366 into lp://staging/compiz/0.9.8

compiz.fix_1016366
Merge into 0.9.8

Proposed by Sam Spilsbury on 2012-06-22

Status:	Merged
Merged at revision:	3274
Proposed branch:	lp://staging/~compiz-team/compiz/compiz.fix_1016366
Merge into:	lp://staging/compiz/0.9.8
Diff against target:	590 lines (+215/-101) 8 files modified plugins/composite/include/composite/composite.h (+5/-0) plugins/composite/src/pixmapbinding/include/pixmapbinding.h (+11/-0) plugins/composite/src/pixmapbinding/src/pixmapbinding.cpp (+4/-1) plugins/composite/src/pixmapbinding/tests/test-composite-pixmapbinding.cpp (+128/-48) plugins/composite/src/privates.h (+4/-1) plugins/composite/src/window.cpp (+23/-13) plugins/opengl/src/window.cpp (+37/-33) src/window.cpp (+3/-5)
To merge this branch:	bzr merge lp://staging/~compiz-team/compiz/compiz.fix_1016366
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Daniel van Vugt		2012-06-22	Approve on 2012-07-02
Review via email: mp+111541@code.staging.launchpad.net

Description of the change

== Problem ==
There are a few cases where textures can become invalid because a pixmap went away and a plugin is keeping the texture around for animations (eg, unmapRefCnt).

This is anywhere where CompositeWindow::release () can be called from, which includes frame updates, map, unmap, resize etc. In those cases, some drivers may not report a failure to bind the texture and we will have an invalid texture.

== Solution ==
Don't allow unbinds of textures kept around for animations in
any case, not just resizing.

== Test ==
Covered by existing unit tests.

Revision history for this message