Compiz Core

Merge lp://staging/~compiz-team/compiz-core/compiz-core.fix_865863 into lp://staging/compiz-core/0.9.5

  1. compiz-core.fix_865863
  2. Merge into 0.9.5
Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 2855
Proposed branch: lp://staging/~compiz-team/compiz-core/compiz-core.fix_865863
Merge into: lp://staging/compiz-core/0.9.5
Diff against target: 119 lines (+56/-49)
1 file modified
src/event.cpp (+56/-49)
To merge this branch: bzr merge lp://staging/~compiz-team/compiz-core/compiz-core.fix_865863
Reviewer Review Type Date Requested Status
Compiz Maintainers Pending
Review via email: mp+78033@code.staging.launchpad.net

This proposal supersedes a proposal from 2011-10-04.

Description of the change

Fixes Bug 865863

Handle windows that reparent into the root window correclty

To post a comment you must log in.
Revision history for this message
Tim Penhey (thumper) wrote :

Do you really need to create the CoreWindow on the stack?

Could you do this:

CoreWindow cw(event->xcreatewindow.window);
cw.manage (priv->getTopWindow (), wa);
priv->createdWindows.remove (&cw);
break;

// NOTE: no delete needed.

Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Yes, because CoreWindow's constructor adds itself to priv->createdWindows. Yeah, I know, that's bad, but I plan to kill CoreWindow anyways

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches