Merge lp://staging/~compiz-team/compiz-core/compiz-core.fix_862719 into lp://staging/compiz-core/0.9.5

Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 2853
Proposed branch: lp://staging/~compiz-team/compiz-core/compiz-core.fix_862719
Merge into: lp://staging/compiz-core/0.9.5
Diff against target: 17 lines (+6/-1)
1 file modified
src/window.cpp (+6/-1)
To merge this branch: bzr merge lp://staging/~compiz-team/compiz-core/compiz-core.fix_862719
Reviewer Review Type Date Requested Status
Robert Carr (community) Approve
Review via email: mp+77809@code.staging.launchpad.net

Description of the change

By default, we filter out hidden windows in CompWindow::focus (), and the check for whether or not the window was hidden is actually meant to be a check for shaded windows, such that moving focus to their client window which is unmapped will not result in an error, but instead move input focus to their frame window.

Unity allows hidden windows to be focused by default such that they will show up in "focus" animations (like scale, ring, shift and friends). This means that the plugin is explicitly allowing focus to be moved to these windows in any case that it returns true for CompWindow::focus () and should handle the focus change by itself. If core gets in the way, then the focus will end up on the frame window or the root window which isn't what we wanted anyways. (Noting here that _NET_ACTIVE_WINDOW would remain s the hidden window which explains why the minimized application title remains in the menubar)

To post a comment you must log in.
Revision history for this message
Robert Carr (robertcarr) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches