eCryptfs

Merge lp://staging/~colin-king/ecryptfs/coverity-fixes into lp://staging/ecryptfs

  1. coverity-fixes
  2. Merge into trunk
Proposed by Colin Ian King
Status: Merged
Merge reported by: Tyler Hicks
Merged at revision: not available
Proposed branch: lp://staging/~colin-king/ecryptfs/coverity-fixes
Merge into: lp://staging/ecryptfs
Diff against target: 0 lines
To merge this branch: bzr merge lp://staging/~colin-king/ecryptfs/coverity-fixes
Reviewer Review Type Date Requested Status
Tyler Hicks Approve
Dustin Kirkland  Needs Fixing
Review via email: mp+189329@code.staging.launchpad.net

Description of the change

Fixed up a bunch of memory leaks and small buffer issues as found by Coverity Scan.

To post a comment you must log in.
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Hey Colin, I see no unmerged revisions or diff against trunk in this branch. Are you sure you pushed some changes?

review: Needs Fixing
Revision history for this message
Colin Ian King (colin-king) wrote :

On 07/10/13 22:43, Dustin Kirkland  wrote:
> Review: Needs Fixing
>
> Hey Colin, I see no unmerged revisions or diff against trunk in this branch. Are you sure you pushed some changes?
>
 Oh now I have looked at it, I have a bad feeling that I may have
accidentally pushed this onto the main trunk. :-(

Colin

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Hmm, I actually merged some of your Coverity fixes a while back.
:-Dustin

On Mon, Oct 7, 2013 at 4:48 PM, Colin King <email address hidden> wrote:
> On 07/10/13 22:43, Dustin Kirkland  wrote:
>> Review: Needs Fixing
>>
>> Hey Colin, I see no unmerged revisions or diff against trunk in this branch. Are you sure you pushed some changes?
>>
> Oh now I have looked at it, I have a bad feeling that I may have
> accidentally pushed this onto the main trunk. :-(
>
> Colin
>
> --
> https://code.launchpad.net/~colin-king/ecryptfs/coverity-fixes/+merge/189329
> You are reviewing the proposed merge of lp:~colin-king/ecryptfs/coverity-fixes into lp:ecryptfs.

Revision history for this message
Colin Ian King (colin-king) wrote :

On 07/10/13 22:51, Dustin Kirkland  wrote:
> Hmm, I actually merged some of your Coverity fixes a while back.
> :-Dustin
>

I think somehow I pushed Revisions 781..790 to the tip of lp:ecryptfs
accidentally, hence there is no diff between that and the tree I
requested a merge for. Apologies for this. My bad.

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Ah, okay, no worries. I'll just take a quick look...
:-Dustin

On Mon, Oct 7, 2013 at 4:57 PM, Colin King <email address hidden> wrote:
> On 07/10/13 22:51, Dustin Kirkland  wrote:
>> Hmm, I actually merged some of your Coverity fixes a while back.
>> :-Dustin
>>
>
> I think somehow I pushed Revisions 781..790 to the tip of lp:ecryptfs
> accidentally, hence there is no diff between that and the tree I
> requested a merge for. Apologies for this. My bad.
>
> --
> https://code.launchpad.net/~colin-king/ecryptfs/coverity-fixes/+merge/189329
> You are reviewing the proposed merge of lp:~colin-king/ecryptfs/coverity-fixes into lp:ecryptfs.

Revision history for this message
Tyler Hicks (tyhicks) wrote :

I looked at the commits in trunk and they all look good. Thanks, Colin!

review: Approve

Preview Diff

Empty

Subscribers

People subscribed via source and target branches