Friends

Merge lp://staging/~codygarver/pantheon-friends/cmake-cleanup into lp://staging/pantheon-friends

  1. cmake-cleanup
  2. Merge into 0.1
Proposed by Cody Garver
Status: Merged
Approved by: David Gomes
Approved revision: 3
Merged at revision: 2
Proposed branch: lp://staging/~codygarver/pantheon-friends/cmake-cleanup
Merge into: lp://staging/pantheon-friends
Diff against target: 103 lines (+44/-38)
1 file modified
CMakeLists.txt (+44/-38)
To merge this branch: bzr merge lp://staging/~codygarver/pantheon-friends/cmake-cleanup
Reviewer Review Type Date Requested Status
David Gomes (community) Approve
Review via email: mp+185948@code.staging.launchpad.net

Commit message

CMakeLists.txt: Clean up and strict dependency requirements

Description of the change

This needs testing, I don't have the require GTK so I can't confirm it works for sure.

To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

Actually valac 0.21.1 is required for having gtk 3.9.x support.

lp://staging/~codygarver/pantheon-friends/cmake-cleanup updated
3. By Cody Garver

Bump valac to 0.21.1 as advised by Rico

Revision history for this message
Cody Garver (codygarver) wrote :

Corrected, thanks.

On Tue, Sep 17, 2013 at 12:36 AM, Rico Tzschichholz <email address hidden>wrote:

> Actually valac 0.21.1 is required for having gtk 3.9.x support.
> --
>
> https://code.launchpad.net/~codygarver/pantheon-friends/cmake-cleanup/+merge/185948
> Your team Developers of Friends is requested to review the proposed merge
> of lp:~codygarver/pantheon-friends/cmake-cleanup into lp:pantheon-friends.
>

--
Cody Garver

Revision history for this message
David Gomes (davidgomes) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches