Merge lp://staging/~cmiller/ubuntu/trusty/apparmor/chromium-new-sandbox-name into lp://staging/ubuntu/trusty/apparmor

Proposed by Chad Miller
Status: Approved
Approved by: Jamie Strandboge
Approved revision: 64
Proposed branch: lp://staging/~cmiller/ubuntu/trusty/apparmor/chromium-new-sandbox-name
Merge into: lp://staging/ubuntu/trusty/apparmor
Diff against target: 69 lines (+15/-4)
3 files modified
debian/changelog (+7/-0)
debian/patches/0001-add-chromium-browser.patch (+6/-4)
profiles/apparmor.d/usr.bin.chromium-browser (+2/-0)
To merge this branch: bzr merge lp://staging/~cmiller/ubuntu/trusty/apparmor/chromium-new-sandbox-name
Reviewer Review Type Date Requested Status
Chad Miller (community) Disapprove
Jamie Strandboge Approve
Ubuntu branches Pending
Review via email: mp+193657@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This is pending a landing ask and will be part of 2.8.0-0ubuntu34. Thanks!

As an aside, it probably makes sense to move this to the chromium-browser packaging like we do with firefox. You can probably follow https://wiki.ubuntu.com/ApparmorProfileMigration if you are interested (along with mimicking firefox's packaging to disable it on install). Note, this would not be a change for SRUs, so it would make the packaging diverge.

review: Approve
Revision history for this message
Chad Miller (cmiller) wrote :

I'm moving the entire apparmor profile to the chromium packaging, so this will be superceded. If it's not already applied, please feel free ignoring it.

review: Disapprove
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

It's already in the archive and in this branch.

Unmerged revisions

64. By Chad Miller

debian/patches/0001-add-chromium-browser.patch: Follow new chromium-browser
sandbox name. Keep old name for now to allow transition. LP: #1247269

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: