lp://staging/~cmiller/desktopcouch/segv-ya-rly

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/desktopcouch

Tim Cole (community): Approve on 2010-03-30

Guillermo Gonzalez: Approve on 2010-03-30

Diff: 59 lines (+15/-4)

2 files modified

desktopcouch/replication_services/example.py (+3/-1)
desktopcouch/replication_services/ubuntuone.py (+12/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #524566: desktopcouch-service crashed with SIGSEGV

Critical

Fix Released

Link a bug report

Related blueprints

143. By Chad Miller on 2010-03-29

Since replication takes a long time (and we are not clever enough yet to
replicate asynchronously), all replication is pushed into a subthread so
that don't block DBus server calls on getPort and such.

However, for some GUI libraries, GUI functions are not allowed to be outside
the main execution thread. Violating that causes undefined behavior.

We need access to the keyring data in replication, and 'gnomekeyring' may
try to display an alert to the user, using GUI functions. Doing so from
inside the replication thread, outside the main thread, can cause SEGV
crashes in deep and mysterious parts of Python and libraries it uses.

Now, add a wrapper for those functions that can call GUI functions. First
test what environment we're in and if in a subthread, ask the twisted reactor
to run the target function in the main execution thread and return the values
down to the subthread.

142. By Eric Casteleijn on 2010-03-22

RecordDict.items() did not return properly wrapped data.

This in turn exposed an IMO more serious bug in CouchDatabaseBase.put_records_batch: that sends Record objects to python-couchdb instead of properly unwrapped dicts (i.e. Record._data). Fixed that bug as well.

141. By Chad Miller on 2010-03-20

Log files can grow large. Expire old ones when we start up and start fresh.

140. By Elliot Murphy on 2010-03-10

Fix a missed rename of simplejson->json

139. By Chad Miller on 2010-03-10

Bump version number.

138. By Elliot Murphy on 2010-03-10

Use the built in json module in python2.6 when the simplejson module is not available.

137. By James Westby on 2010-03-10

Add with_auth and with_keyring arguments to Context.

If with_auth is False then a couch started in the created context won't require or accept credentials. This makes it not really a desktopcouch, but the facilities for starting and stopping couchdb with a restricted configuration can be hugely useful to other projects to use in e.g. test suites.

If with_keyring is False then the credentials won't be read from or stored to gnome-keyring, so that if it is a non-default context (e.g. in a testsuite) it doesn't intefere with the user's desktopcouch, as gnome-keyring is the only global object that Context interacts with.

Use a mock keyring during the tests to isolate them from the user more.

136. By Chad Miller on 2010-03-10

Revert feature of calling DBus on desktopcouch.find_port() . This causes a problem with some threaded apps, like Gwibber.

135. By Chad Miller on 2010-03-10

Add class to ubuntuone replication that allows one to set and unset and retreive exclusions to what is replicated to Ubuntu One servers.

134. By James Westby on 2010-03-04

Report the directory we are looking in when we can't find the fds.

It's not always going to be all that useful (e.g. if the process has
ended), but it's going to be more useful than just knowing it was looking
in /proc, and implicitly tells you the pid that it thinks the child should
have.