Merge lp://staging/~cmiller/desktopcouch/find-port-runtimeerror2 into lp://staging/desktopcouch
Proposed by
Chad Miller
| Status: | Merged |
|---|---|
| Approved by: | Eric Casteleijn |
| Approved revision: | 155 |
| Merged at revision: | 157 |
| Proposed branch: | lp://staging/~cmiller/desktopcouch/find-port-runtimeerror2 |
| Merge into: | lp://staging/desktopcouch |
| Diff against target: |
39 lines (+8/-1) 1 file modified
desktopcouch/__init__.py (+8/-1) |
| To merge this branch: | bzr merge lp://staging/~cmiller/desktopcouch/find-port-runtimeerror2 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Eric Casteleijn (community) | Approve | ||
| Tim Cole (community) | Approve | ||
|
Review via email:
|
|||
Commit message
A possible fix for a bug I can't reproduce, Bug#465216. It is possible that two calls to find_port will happen near the same time. The steps tostarting up couchdb are 1) start couchdb if not already running, 2) get pid, 3) get port. Two processes can be in that chain at the same time, and only one will win the race of having started the winning couchdb. In that case, each should be willing to restart the entire chain over.
To post a comment you must log in.
Revision history for this message
| Guillermo Gonzalez (verterok) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Sensible, I think.