Merge lp://staging/~clint-fewbar/ubuntu/maverick/libdbi-drivers/merge-upstream-release-0.8.3-1 into lp://staging/ubuntu/maverick/libdbi-drivers

Proposed by Clint Byrum
Status: Work in progress
Proposed branch: lp://staging/~clint-fewbar/ubuntu/maverick/libdbi-drivers/merge-upstream-release-0.8.3-1
Merge into: lp://staging/ubuntu/maverick/libdbi-drivers
Diff against target: 278 lines (+159/-10)
9 files modified
debian/changelog (+15/-1)
debian/control (+12/-8)
debian/patches/remove_test_17_pgsql.patch (+24/-0)
debian/patches/series (+1/-0)
debian/rules (+14/-1)
debian/run_test_driver.sh (+21/-0)
debian/source/format (+1/-0)
debian/test_mysql.sh (+31/-0)
debian/test_postgres.sh (+40/-0)
To merge this branch: bzr merge lp://staging/~clint-fewbar/ubuntu/maverick/libdbi-drivers/merge-upstream-release-0.8.3-1
Reviewer Review Type Date Requested Status
Clint Byrum (community) Disapprove
Ubuntu branches Pending
Review via email: mp+32213@code.staging.launchpad.net

Description of the change

- Runs comprehensive tests for sqlite, sqlite3, mysql, and postgresql.
- lintian clean now

To post a comment you must log in.
Revision history for this message
Stefano Rivera (stefanor) wrote :

The source format and standards-version changes seem like unnecessary divergance from Debian (unless the Debian maintainer plans the same change).

It's always nice to have DEP3 headers on patches, although I suppose this one is self-explanatory enough.

Modifying existing changelog entries isn't right :)

It fails to build on my machine which already has a running mysql. I don't know a neat solution to that problem, though...

Marking wip

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

I've been working with Thomas Goirand, the Debian Maintainer, and he's improved the tests quite a bit, and will be uploading them along with 0.8.3-1 after squeeze is unfrozen.

Its reported here:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=592652

and most of the discussion is actually recorded here:

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=592447

So, I'd say this merge proposal should not happen as it stands, and we should just sync w/ Debian when he uploads.

review: Disapprove

Unmerged revisions

10. By Clint Byrum

* debian/patches/remove_test_17_pgsql.patch: test fails on pgsql
  - upstream bug https://sourceforge.net/tracker/?func=detail&aid=3042565&group_id=65979&atid=512945
* changing to quilt 3.0 format
* debian/control:
  - updating to debian policy 3.8.4
  - fixing lintian complaints about debhelper and misc:Depends
  - Adding build depends for mysql and postgres server (for tests)
  - Adding build depend for language-pack-en for postgres test

9. By Clint Byrum

cleaning up test-stamp

8. By Clint Byrum

fixing dependencies and removing fakeroot hack

7. By Clint Byrum

* debian/rules: run tests for sqlite, sqlite3, mysql, pgsql (LP: #614496)
* debian/patches/remove_test_17_pgsql.patch: test fails on pgsql
* changing to quilt 3.0 format

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: