pyjuju

Merge lp://staging/~clint-fewbar/pyjuju/remove-default-ami into lp://staging/pyjuju

  1. remove-default-ami
  2. Merge into trunk
Proposed by Clint Byrum
Status: Rejected
Rejected by: Gustavo Niemeyer
Proposed branch: lp://staging/~clint-fewbar/pyjuju/remove-default-ami
Merge into: lp://staging/pyjuju
Diff against target: 20 lines (+2/-2)
1 file modified
ensemble/environment/config.py (+2/-2)
To merge this branch: bzr merge lp://staging/~clint-fewbar/pyjuju/remove-default-ami
Reviewer Review Type Date Requested Status
Gustavo Niemeyer Disapprove
Jim Baker (community) Approve
Review via email: mp+71278@code.staging.launchpad.net

Description of the change

Trivial change that will make ensemble validate default-image-id instead of default-ami.

To post a comment you must log in.
Revision history for this message
Jim Baker (jimbaker) wrote :

+1, really a trivial. Verified that this old branch still works when merged against trunk.

review: Approve
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

Looks good, but please add a test preventing the issue from regressing.

review: Needs Fixing
Revision history for this message
Gustavo Niemeyer (niemeyer) wrote :

I guess those tests aren't coming. :-)

review: Disapprove

Unmerged revisions

312. By Clint Byrum

fix incorrect key in schema validator

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: