Merge lp://staging/~clint-fewbar/pyjuju/fix-empty-config-get into lp://staging/pyjuju

Proposed by Clint Byrum
Status: Merged
Approved by: William Reade
Approved revision: 429
Merged at revision: 436
Proposed branch: lp://staging/~clint-fewbar/pyjuju/fix-empty-config-get
Merge into: lp://staging/pyjuju
Diff against target: 61 lines (+35/-1)
2 files modified
juju/hooks/cli.py (+1/-1)
juju/hooks/tests/test_cli.py (+34/-0)
To merge this branch: bzr merge lp://staging/~clint-fewbar/pyjuju/fix-empty-config-get
Reviewer Review Type Date Requested Status
William Reade (community) Approve
Kapil Thangavelu (community) Approve
Review via email: mp+84869@code.staging.launchpad.net

Description of the change

Simple bug fix, adds tests to prevent regression in the future and better define what "format_smart" is supposed to do.

To post a comment you must log in.
Revision history for this message
Kapil Thangavelu (hazmat) wrote :

lgtm

review: Approve
Revision history for this message
William Reade (fwereade) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: