pyjuju

Merge lp://staging/~clint-fewbar/pyjuju/ec2-use-ip-address into lp://staging/pyjuju

ec2-use-ip-address
Merge into trunk

Proposed by Clint Byrum on 2012-08-09

Status:

Work in progress

Proposed branch:

lp://staging/~clint-fewbar/pyjuju/ec2-use-ip-address

Merge into:

lp://staging/pyjuju

Diff against target:

315 lines (+163/-16)

7 files modified

juju/providers/ec2/__init__.py (+2/-1)
juju/providers/ec2/launch.py (+8/-1)
juju/providers/ec2/machine.py (+30/-4)
juju/providers/ec2/tests/common.py (+18/-2)
juju/providers/ec2/tests/test_getmachines.py (+4/-0)
juju/providers/ec2/tests/test_launch.py (+21/-2)
juju/providers/ec2/tests/test_machine.py (+80/-6)

To merge this branch:

bzr merge lp://staging/~clint-fewbar/pyjuju/ec2-use-ip-address

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Juju Engineering		2012-08-09	Pending
Review via email: mp+119021@code.staging.launchpad.net

Description of the change

Use ipAddress as a fallback for dnsName

Use ipAddress as a fallback if dnsName is unresolvable

https://codereview.appspot.com/6441126/

Revision history for this message

Robert Collins (lifeless) wrote on 2012-08-09:

This is better than what we have today (per the analysis I provided for use of ips), but it has a significant flaw: many folk have DNS servers (e.g. opendns) that resolve DNS names that don't exist. You'll need a much more complex algorithm to determine 'DNS is broken' than merely fails-to-resolve.

Revision history for this message

Kapil Thangavelu (hazmat) wrote on 2012-08-13:

I'm confused, i thought we had said this wasn't nesc given the openstack native provider (which uses ip addresses).

Revision history for this message

Clint Byrum (clint-fewbar) wrote on 2012-08-13:

Its less important for sure. However, it would help for private clouds built on other EC2 implementations like Eucalyptus.

Revision history for this message

Clint Byrum (clint-fewbar) wrote on 2012-09-18:

I'm less interested in pursuing this approach now that I have tinkered with it. This makes the ec2 provider less robust without good cause. I think a better approach, such as a setting "use-ip" would be more appropriate for those rare private EC2 clouds that won't have resolvable dns. For common private openstack clouds, the native openstack provider makes more sense.

Unmerged revisions

566. By Clint Byrum on 2012-08-09: skip ip_address tests on txaws that does not support it
565. By Clint Byrum on 2012-08-09: refactor to do lookup in machine_from_instance
564. By Clint Byrum on 2012-08-08: add support for older txaws api
563. By Clint Byrum on 2012-08-08: Use ip address when we cannot lookup the hostname given by the provider