Merge lp://staging/~clint-fewbar/charms/precise/mysql/add-monitors into lp://staging/charms/mysql
Proposed by
Clint Byrum
| Status: | Merged |
|---|---|
| Approved by: | Mark Mims |
| Approved revision: | 81 |
| Merged at revision: | 75 |
| Proposed branch: | lp://staging/~clint-fewbar/charms/precise/mysql/add-monitors |
| Merge into: | lp://staging/charms/mysql |
| Diff against target: |
134 lines (+51/-5) 9 files modified
hooks/config-changed (+2/-2) hooks/install (+3/-2) hooks/monitors-relation-broken (+8/-0) hooks/monitors-relation-departed (+3/-0) hooks/monitors-relation-joined (+7/-0) hooks/monitors.common.bash (+8/-0) metadata.yaml (+6/-0) monitors.yaml (+13/-0) revision (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~clint-fewbar/charms/precise/mysql/add-monitors |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Mark Mims (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add support for monitors interface.
Description of the change
This adds support for the 'monitors' interface. Please see
https:/
For information regarding that interface.
To post a comment you must log in.
Revision history for this message
| Mark Mims (mark-mims) | # |
review:
Approve
Revision history for this message
| Mark Mims (mark-mims) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
discussion/
Please move included scripts into a separate directory like
`$CHARM_DIR/lib` or `$CHARM_
in the `hooks` directory. Charm readability is the goal for
our main series of charms like mysql.
We really should change the `.bash` file extensions to the more standard `.sh`...
/me thinks it's just a tad too pedantic to make a distinction between the two.
Why raise even the slightest possibility for people or editors to be confused?