lp://staging/~cjwatson/txpkgupload/ipv4-mapped-pasv
Created by
Colin Watson
and last modified
- Get this branch:
- bzr branch lp://staging/~cjwatson/txpkgupload/ipv4-mapped-pasv
Only
Colin Watson
can upload to this branch. If you are
Colin Watson
please log in for upload directions.
Branch merges
Propose for merging
No branches
dependent on this one.
- William Grant (community): Approve (code)
-
Diff: 95 lines (+47/-2)3 files modifiedrequirements.txt (+1/-1)
setup.py (+1/-0)
src/txpkgupload/twistedftp.py (+45/-1)
Related bugs
Bug #1836059: dput via ftp to ppa.launchpad.net failure | Critical | Fix Released |
Related blueprints
Branch information
Recent revisions
- 46. By Colin Watson
-
Fix behaviour of PASV with IPv4-mapped addresses.
When receiving a connection to an IPv6 endpoint using an IPv4-mapped
address (possible on some IPv6 stacks), PASV can work but needs to
return a properly-encoded IPv4 address. Including the leading "::ffff:"
in the response appears to confuse connection tracking in some
firewalls.This is a backport from a commit in
https://github. com/twisted/ twisted/ pull/1149, with the only changes being
minor adjustments to symbol names and using six.ensure_text rather than the
private twisted.python. compat. _coercedUnicode . As before, getting the tests
backported here was unreasonably difficult, but the Twisted PR has
reasonable coverage.
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp://staging/~lazr-developers/txpkgupload/trunk