Merge lp://staging/~cjwatson/storm/transaction-2.4.0 into lp://staging/storm

Proposed by Colin Watson
Status: Merged
Merged at revision: 489
Proposed branch: lp://staging/~cjwatson/storm/transaction-2.4.0
Merge into: lp://staging/storm
Diff against target: 44 lines (+15/-1)
2 files modified
NEWS (+1/-0)
tests/zope/zstorm.py (+14/-1)
To merge this branch: bzr merge lp://staging/~cjwatson/storm/transaction-2.4.0
Reviewer Review Type Date Requested Status
Simon Poirier (community) Approve
Adam Collard (community) Approve
Review via email: mp+368072@code.staging.launchpad.net

Commit message

Cope with ThreadTransactionManager changes in transaction 2.4.0.

Description of the change

transaction 2.4.0 changed ThreadTransactionManager to wrap TransactionManager rather than inheriting from it, which broke tests because the wrapper doesn't have a "free" method. Apply a somewhat ugly workaround.

I've tested this with both transaction 2.3.0 and 2.4.0 (with the aid of an as-yet-unpushed branch to add tox testing support).

To post a comment you must log in.
Revision history for this message
Alberto Donato (ack) :
Revision history for this message
Colin Watson (cjwatson) :
Revision history for this message
Adam Collard (adam-collard) wrote :

+1

review: Approve
Revision history for this message
Simon Poirier (simpoir) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: