Merge lp://staging/~cjwatson/storm/tox into lp://staging/storm

Proposed by Colin Watson
Status: Merged
Merged at revision: 490
Proposed branch: lp://staging/~cjwatson/storm/tox
Merge into: lp://staging/storm
Diff against target: 483 lines (+51/-323)
8 files modified
.bzrignore (+1/-0)
MANIFEST.in (+1/-1)
Makefile (+4/-13)
NEWS (+1/-0)
dev/ubuntu-deps (+4/-1)
ez_setup.py (+0/-284)
setup.py (+25/-24)
tox.ini (+15/-0)
To merge this branch: bzr merge lp://staging/~cjwatson/storm/tox
Reviewer Review Type Date Requested Status
Simon Poirier (community) Approve
Review via email: mp+368142@code.staging.launchpad.net

Commit message

Add tox testing support.

Description of the change

My goal here is to make it easier to test with various versions of dependencies, and in particular to make it easier to test with multiple Python versions in order to facilitate a port to Python 3.

This has IMO already pulled its weight by uncovering https://code.launchpad.net/~cjwatson/storm/transaction-2.4.0/+merge/368072. I haven't made that a formal prerequisite, but it or something like it should be merged before this.

To post a comment you must log in.
Revision history for this message
Simon Poirier (simpoir) wrote :

I"m generally ok with this change, but I do get some failures when running test under tox+py27 vs py27 on a fresh container. Am I missing something or will this be in a follow-up branch?

review: Needs Information
Revision history for this message
Colin Watson (cjwatson) wrote :

What failures do you see? I have a couple of associated MPs that fix some failures, but I'd need to know details of your problems to tell whether they're relevant.

Revision history for this message
Simon Poirier (simpoir) wrote :

checked with the other branches +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: