Storm

Merge lp://staging/~cjwatson/storm/restore-mysql into lp://staging/storm

restore-mysql
Merge into trunk

Proposed by Colin Watson on 2021-04-06

Status:	Merged
Merged at revision:	568
Proposed branch:	lp://staging/~cjwatson/storm/restore-mysql
Merge into:	lp://staging/storm
Prerequisite:	lp://staging/~cjwatson/storm/py27-py35-workarounds
Diff against target:	995 lines (+708/-46) 13 files modified .bzrignore (+1/-0) MANIFEST.in (+1/-1) NEWS (+1/-0) README (+22/-41) dev/test (+123/-2) dev/ubuntu-deps (+3/-0) setup.py (+2/-0) storm/databases/mysql.py (+246/-0) storm/docs/tutorial.rst (+2/-2) storm/tests/databases/base.py (+2/-0) storm/tests/databases/mysql.py (+167/-0) storm/tests/store/base.py (+30/-0) storm/tests/store/mysql.py (+108/-0)
To merge this branch:	bzr merge lp://staging/~cjwatson/storm/restore-mysql
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Ioana Lasc (community)		Approve on 2021-04-15
Storm Developers	2021-04-06	Pending
Review via email: mp+400633@code.staging.launchpad.net

Commit message

Restore MySQL support.

Description of the change

We've had some requests to put this back, and it's reasonably straightforward to support. The only tricky bit was arranging for automatic test database provisioning; the only near-equivalent of postgresfixture that I could find is pytest-specific, but it's not too hard to inline the necessary setup and teardown code.

MySQL support was dropped in https://code.launchpad.net/~ack/storm/drop-mysql-support/+merge/288652, but it's clear that the people doing that work were labouring under the assumption that Storm is only used within Canonical, which is demonstrably untrue.

Revision history for this message

Colin Watson (cjwatson) wrote on 2021-04-06:

https://paste.ubuntu.com/p/CpVtdGRZgm/ is a diff of the three "new" (restored) files in this branch against the revision immediately before their previous removal, which may make them easier to review. As you can see, there are a few changes for Python 3 support, test directory reorganization, and to support automatic test database provisioning, but they're relatively short.