Merge lp://staging/~cjwatson/storm/require-psycopg2-2.3.0 into lp://staging/storm

Proposed by Colin Watson
Status: Merged
Merged at revision: 497
Proposed branch: lp://staging/~cjwatson/storm/require-psycopg2-2.3.0
Merge into: lp://staging/storm
Diff against target: 30 lines (+4/-5)
2 files modified
setup.py (+1/-1)
storm/databases/postgres.py (+3/-4)
To merge this branch: bzr merge lp://staging/~cjwatson/storm/require-psycopg2-2.3.0
Reviewer Review Type Date Requested Status
Adam Collard (community) Approve
Review via email: mp+368206@code.staging.launchpad.net

Commit message

Require psycopg2 >= 2.3.0 for two-phase commit support.

Description of the change

Some of Storm's tests fail with older versions of psycopg2, because two-phase commit support was only introduced in 2.3.0. This impedes establishing test matrixes to work out whether workarounds for old bugs are still necessary (I ran into this while looking into the state of Unicode query support).

It looks as though most of Storm would probably still work OK with earlier versions, and just require a little extra code to ensure that we raise FeatureError or similar when somebody tries to use two-phase commits with an old psycopg2 version. However, I can't find any evidence of anyone complaining about this in the seven years since Storm gained two-phase commit support, and psycopg2 2.3.0 was released in December 2010, so doing work to support older versions now doesn't seem like a sensible use of time.

To post a comment you must log in.
Revision history for this message
Adam Collard (adam-collard) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: