Merge lp://staging/~cjwatson/storm/remove-psycopg-unicode-workaround into lp://staging/storm
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Merged at revision: | 496 |
| Proposed branch: | lp://staging/~cjwatson/storm/remove-psycopg-unicode-workaround |
| Merge into: | lp://staging/storm |
| Diff against target: |
20 lines (+0/-10) 1 file modified
storm/databases/postgres.py (+0/-10) |
| To merge this branch: | bzr merge lp://staging/~cjwatson/storm/remove-psycopg-unicode-workaround |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Adam Collard (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Remove PostgresConnect
Description of the change
This workaround was added in 2007, and presumably there was some psycopg2 problem at the time that required it. However, I've tested as far back as psycopg2 2.0.10 (the oldest version still available on PyPI) and there's no sign of it; I've also successfully run the full Launchpad test suite without this workaround. I think this must have been a psycopg2 bug that was fixed a long time ago, and it now seems to be safe to drop the workaround.
(My motivation here is that it's one fewer thing that needs porting to Python 3.)
To post a comment you must log in.
Revision history for this message
| Adam Collard (adam-collard) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
