Storm

Merge lp://staging/~cjwatson/storm/py3-special-methods into lp://staging/storm

  1. py3-special-methods
  2. Merge into trunk
Proposed by Colin Watson
Status: Merged
Merged at revision: 511
Proposed branch: lp://staging/~cjwatson/storm/py3-special-methods
Merge into: lp://staging/storm
Diff against target: 46 lines (+8/-0)
3 files modified
storm/expr.py (+4/-0)
storm/info.py (+2/-0)
storm/references.py (+2/-0)
To merge this branch: bzr merge lp://staging/~cjwatson/storm/py3-special-methods
Reviewer Review Type Date Requested Status
Colin Watson (community) Approve
Review via email: mp+371166@code.staging.launchpad.net

Commit message

Provide needed methods for python3.

Description of the change

When a class defined __eq__ it needs to define __hash__ to or else it will not be hashable.

Also, __div__ doesn't exist anymore in python3. Classes are supposed to implement both __floordiv__ and __truediv__ instead.

This is extracted from https://bazaar.launchpad.net/~bellini666/storm/py3/revision/490 in order to be able to land it independently.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

I'll review this myself since I just extracted it from somebody else's MP.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: