Merge lp://staging/~cjwatson/storm/py3-metaclass into lp://staging/storm
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Merged at revision: | 523 |
| Proposed branch: | lp://staging/~cjwatson/storm/py3-metaclass |
| Merge into: | lp://staging/storm |
| Diff against target: |
190 lines (+30/-22) 6 files modified
storm/base.py (+3/-2) storm/sqlobject.py (+3/-2) tests/info.py (+3/-2) tests/mocker.py (+9/-6) tests/properties.py (+4/-2) tests/store/base.py (+8/-8) |
| To merge this branch: | bzr merge lp://staging/~cjwatson/storm/py3-metaclass |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Simon Poirier (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Use six.with_metaclass to support Python 3's metaclass syntax.
To post a comment you must log in.
Revision history for this message
| Kristian Glass (doismellburning) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
For what it's worth, this definitely looks plausible and reasonable to me, but I'm not currently familiar enough with metaclasses, metaclass changes between 2/3, and/or Storm's usage thereof, to necessarily give a _positive_ review