Merge lp://staging/~cjwatson/storm/postgresfixture into lp://staging/storm

Proposed by Colin Watson
Status: Merged
Merged at revision: 536
Proposed branch: lp://staging/~cjwatson/storm/postgresfixture
Merge into: lp://staging/storm
Diff against target: 425 lines (+125/-60)
12 files modified
.bzrignore (+2/-0)
MANIFEST.in (+2/-0)
NEWS (+6/-0)
README (+0/-1)
dev/db-setup (+0/-45)
setup.py (+1/-0)
storm/tests/databases/base.py (+23/-8)
storm/tests/databases/postgres.py (+33/-0)
storm/tests/databases/proxy.py (+18/-3)
storm/tests/mocker.py (+1/-1)
test (+39/-0)
tox.ini (+0/-2)
To merge this branch: bzr merge lp://staging/~cjwatson/storm/postgresfixture
Reviewer Review Type Date Requested Status
Simon Poirier (community) Approve
Review via email: mp+373379@code.staging.launchpad.net

Commit message

Use postgresfixture to simplify developer setup.

Description of the change

Since postgresfixture provides a cluster listening on a Unix-domain socket, we use a TCP proxy for tests that require a TCP connection string.

This necessitated some minor improvements to test cleanup code to ensure that the temporary database can be dropped cleanly.

To post a comment you must log in.
Revision history for this message
Simon Poirier (simpoir) wrote :

+1 LGTM

review: Approve
Revision history for this message
Colin Watson (cjwatson) :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: