Merge lp://staging/~cjwatson/storm/mysql-8.0.24-compat into lp://staging/storm
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Merged at revision: | 574 |
| Proposed branch: | lp://staging/~cjwatson/storm/mysql-8.0.24-compat |
| Merge into: | lp://staging/storm |
| Diff against target: |
74 lines (+17/-5) 5 files modified
NEWS (+8/-0) dev/test (+2/-1) storm/databases/mysql.py (+4/-1) storm/tests/databases/mysql.py (+2/-2) storm/tests/store/base.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~cjwatson/storm/mysql-8.0.24-compat |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ioana Lasc (community) | Approve | ||
| Storm Developers | Pending | ||
|
Review via email:
|
|||
Commit message
Fix test compatibility with MySQL >= 8.0.24.
Description of the change
https:/
Client applications and test suite plugins now report utf8mb3 rather than utf8 when writing character set names. (Bug #32164079, Bug #32164125)
This broke the Storm test suite. Adjust it slightly to cope. Ideally we should use utf8mb4 instead, but I'm not quite sure to what extent this might break existing applications, so stick to what we know for now.
To post a comment you must log in.
Revision history for this message
| Ioana Lasc (ilasc) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
