Merge lp://staging/~cjwatson/storm/expr-spacing into lp://staging/storm
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Merged at revision: | 542 |
| Proposed branch: | lp://staging/~cjwatson/storm/expr-spacing |
| Merge into: | lp://staging/storm |
| Diff against target: |
298 lines (+47/-37) 4 files modified
NEWS (+8/-0) storm/expr.py (+7/-7) storm/tests/databases/postgres.py (+1/-1) storm/tests/expr.py (+31/-29) |
| To merge this branch: | bzr merge lp://staging/~cjwatson/storm/expr-spacing |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Simon Poirier (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Add whitespace around "<<", ">>", "+", "-", "*", "/", and "%" operators.
Description of the change
I ran into this when using flask-storm's RequestTracer, which uses sqlparse to help it substitute parameters in its trace output; it was getting confused because sqlparse parses "expr+%s" as "expr", "+%", "s" rather than "expr", "+", "%s". Adding surrounding whitespace removes the ambiguity here.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
+1 LGTM