Merge lp://staging/~cjwatson/storm/cextensions-rename-dunder into lp://staging/storm

Proposed by Colin Watson
Status: Merged
Merged at revision: 508
Proposed branch: lp://staging/~cjwatson/storm/cextensions-rename-dunder
Merge into: lp://staging/storm
Diff against target: 161 lines (+24/-24)
1 file modified
storm/cextensions.c (+24/-24)
To merge this branch: bzr merge lp://staging/~cjwatson/storm/cextensions-rename-dunder
Reviewer Review Type Date Requested Status
Simon Poirier (community) Approve
Review via email: mp+368451@code.staging.launchpad.net

Commit message

Rename double-underscore identifiers in C extensions.

Description of the change

Unlike Python, identifiers that begin with two underscores are reserved in C. This happens not to have caused a practical problem as yet, but it could. These names aren't exposed to Python, so there's no problem just renaming them to begin with a single underscore instead.

To post a comment you must log in.
Revision history for this message
Simon Poirier (simpoir) wrote :

+1 good change

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: