Storm

Merge lp://staging/~cjwatson/storm/case-sensitive-like-helpers into lp://staging/storm

case-sensitive-like-helpers
Merge into trunk

Proposed by Colin Watson on 2020-12-07

Status:	Merged
Merged at revision:	566
Proposed branch:	lp://staging/~cjwatson/storm/case-sensitive-like-helpers
Merge into:	lp://staging/storm
Diff against target:	103 lines (+43/-6) 3 files modified NEWS (+10/-0) storm/expr.py (+6/-6) storm/tests/expr.py (+27/-0)
To merge this branch:	bzr merge lp://staging/~cjwatson/storm/case-sensitive-like-helpers
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Ioana Lasc (community)		Approve on 2020-12-15
Storm Developers	2020-12-07	Pending
Review via email: mp+394982@code.staging.launchpad.net

Commit message

Add optional case_sensitive argument to several Like helpers.

Description of the change

Comparable.startswith, Comparable.endswith, and Comparable.contains_string are convenience wrappers around Like, but none of them supported the case_sensitive option which Like supports on PostgreSQL. This made using PostgreSQL's ILIKE extension somewhat cumbersome in places: see https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/394702 for a verbose workaround that would be simpler with the aid of this patch (e.g. `POMsgID.msgid.contains_string(text, case_sensitive=False)`).