Merge lp://staging/~cjwatson/storm/capture-tracer-modern-fixtures into lp://staging/storm
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Merged at revision: | 559 |
| Proposed branch: | lp://staging/~cjwatson/storm/capture-tracer-modern-fixtures |
| Merge into: | lp://staging/storm |
| Diff against target: |
45 lines (+3/-6) 3 files modified
NEWS (+1/-0) setup.py (+1/-4) storm/testing.py (+1/-2) |
| To merge this branch: | bzr merge lp://staging/~cjwatson/storm/capture-tracer-modern-fixtures |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ioana Lasc (community) | Approve | ||
| Storm Developers | Pending | ||
|
Review via email:
|
|||
Commit message
Convert CaptureTracer to the improved API in fixtures >= 1.3.0.
Description of the change
As the fixtures CHANGES file says:
* Fixture.setUp should no longer be overridden in subclasses. Instead
override _setUp. This permits the Fixture base class to detect failures
during _setUp and trigger any registered cleanups, attach any details
to the failure exception and propagate that to callers. Overriding of
setUp is still supported: this adds a new interface for simpler
implementation of the contract of a fixture.
(Robert Collins, #1456361, #1456353)
fixtures 1.3.0 was released in 2015.
My main immediate motivation for this was to stop CaptureTracer.setUp showing up in API documentation.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
makes sense and looks good