Merge lp://staging/~cjwatson/rabbitfixture/less-aggressive-sigterm into lp://staging/rabbitfixture
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Merged at revision: | 57 |
| Proposed branch: | lp://staging/~cjwatson/rabbitfixture/less-aggressive-sigterm |
| Merge into: | lp://staging/rabbitfixture |
| Diff against target: |
33 lines (+8/-1) 2 files modified
NEWS.rst (+7/-0) rabbitfixture/server.py (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~cjwatson/rabbitfixture/less-aggressive-sigterm |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrey Fedoseev (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Only send SIGTERM once while stopping RabbitServerRunner.
Description of the change
It's sent to the whole process group, and that can itself interfere with the shutdown process if we send it frequently and repeatedly. I noticed that Launchpad's `RabbitMQLayer` was oddly slow to shut down sometimes, and tracked that down to this.
To post a comment you must log in.
Revision history for this message
| Andrey Fedoseev (andrey-fedoseev) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
