OOPS model

Merge lp://staging/~cjwatson/python-oops/py3 into lp://staging/python-oops

  1. py3
  2. Merge into trunk
Proposed by Colin Watson
Status: Merged
Merged at revision: 38
Proposed branch: lp://staging/~cjwatson/python-oops/py3
Merge into: lp://staging/python-oops
Diff against target: 308 lines (+49/-24)
12 files modified
.bzrignore (+1/-0)
NEWS (+2/-0)
README (+1/-1)
oops/config.py (+4/-2)
oops/createhooks.py (+8/-8)
oops/publishers.py (+4/-2)
oops/tests/__init__.py (+2/-0)
oops/tests/test_config.py (+2/-0)
oops/tests/test_createhooks.py (+5/-4)
oops/tests/test_publishers.py (+14/-5)
setup.py (+5/-2)
versions.cfg (+1/-0)
To merge this branch: bzr merge lp://staging/~cjwatson/python-oops/py3
Reviewer Review Type Date Requested Status
Robert Collins (community) Approve
Launchpad code reviewers Pending
Review via email: mp+337332@code.staging.launchpad.net

Commit message

Add Python 3 support.

Description of the change

I ignored buildout and did everything in a virtualenv with pip.

I only noticed https://code.launchpad.net/~ralsina/python-oops/py3/+merge/261557 after finishing this, but I think my safe_unicode conversion is more correct.

To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

Looks fine to me.

Note that

str == bytes would be more idiomatic as
str is bytes

but its functionally equivalent so shrug :).

review: Approve
lp://staging/~cjwatson/python-oops/py3 updated
39. By Colin Watson

More idiomatic bytes/str test.

Revision history for this message
Colin Watson (cjwatson) wrote :

Ah, of course, thanks. Done.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: