python-jujuclient

Merge lp://staging/~cjwatson/python-jujuclient/websocket-client-compat into lp://staging/python-jujuclient

  1. websocket-client-compat
  2. Merge into trunk
Proposed by Colin Watson
Status: Merged
Merged at revision: 99
Proposed branch: lp://staging/~cjwatson/python-jujuclient/websocket-client-compat
Merge into: lp://staging/python-jujuclient
Diff against target: 14 lines (+4/-0)
1 file modified
jujuclient/connector.py (+4/-0)
To merge this branch: bzr merge lp://staging/~cjwatson/python-jujuclient/websocket-client-compat
Reviewer Review Type Date Requested Status
David Britton (community) Approve
Review via email: mp+347505@code.staging.launchpad.net

Commit message

Work around SSL option handling bug in some versions of websocket-client.

Description of the change

This works around https://github.com/websocket-client/websocket-client/issues/334, which was broken in 0.44.0 and maybe also 0.43.0, and fixed in 0.45.0.

Unfortunately 0.44.0 is what's in bionic, so at the moment python-jujuclient is broken out of the box in bionic. I think SRUing this patch there would be a good idea.

To post a comment you must log in.
Revision history for this message
David Britton (dpb) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: