Meliae

Merge lp://staging/~cjwatson/meliae/py3-old-style-classes into lp://staging/meliae

  1. py3-old-style-classes
  2. Merge into trunk
Proposed by Colin Watson
Status: Merged
Approved by: John A Meinel
Approved revision: 212
Merged at revision: 212
Proposed branch: lp://staging/~cjwatson/meliae/py3-old-style-classes
Merge into: lp://staging/meliae
Diff against target: 37 lines (+5/-0)
2 files modified
meliae/_scanner_core.c (+2/-0)
meliae/tests/test__scanner.py (+3/-0)
To merge this branch: bzr merge lp://staging/~cjwatson/meliae/py3-old-style-classes
Reviewer Review Type Date Requested Status
John A Meinel Approve
Review via email: mp+378339@code.staging.launchpad.net

Commit message

Don't handle old-style classes on Python 3.

Description of the change

Python 3 only has new-style classes.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

Incidentally, unittest.skipIf requires Python >= 2.7. If you think 2.6 support is still important then I can try to come up with some variant approach, but given https://devguide.python.org/devcycle/#end-of-life-branches it didn't seem likely to be a problem.

Revision history for this message
John A Meinel (jameinel) wrote :

No, I'm not worried about 2.6 anymore (I think this was actually originally written against 2.5 since we had to implement our own sizeof)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: