Meliae

Merge lp://staging/~cjwatson/meliae/py3-duck-type-file into lp://staging/meliae

  1. py3-duck-type-file
  2. Merge into trunk
Proposed by Colin Watson
Status: Merged
Approved by: John A Meinel
Approved revision: 223
Merged at revision: 224
Proposed branch: lp://staging/~cjwatson/meliae/py3-duck-type-file
Merge into: lp://staging/meliae
Diff against target: 20 lines (+6/-4)
1 file modified
meliae/loader.py (+6/-4)
To merge this branch: bzr merge lp://staging/~cjwatson/meliae/py3-duck-type-file
Reviewer Review Type Date Requested Status
John A Meinel Approve
Review via email: mp+380583@code.staging.launchpad.net

Commit message

Duck-type files in meliae.loader.load.

Description of the change

The "file" builtin doesn't exist on Python 3, but we really just need to know whether the source object has a "fileno" method, so test for that directly.

To post a comment you must log in.
Revision history for this message
John A Meinel (jameinel) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: