libusermetrics

Merge lp://staging/~cjwatson/libusermetrics/valgrind-optional into lp://staging/libusermetrics

  1. valgrind-optional
  2. Merge into trunk
Proposed by Colin Watson
Status: Approved
Approved by: Pete Woods
Approved revision: 150
Proposed branch: lp://staging/~cjwatson/libusermetrics/valgrind-optional
Merge into: lp://staging/libusermetrics
Diff against target: 26 lines (+3/-2)
2 files modified
debian/control (+1/-1)
debian/rules (+2/-1)
To merge this branch: bzr merge lp://staging/~cjwatson/libusermetrics/valgrind-optional
Reviewer Review Type Date Requested Status
Pete Woods (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+211563@code.staging.launchpad.net

Commit message

Only require valgrind on architectures where it is available.

Description of the change

This should allow libusermetrics to build on the Ubuntu architectures (arm64 and ppc64el) where valgrind is not currently available.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:150
http://jenkins.qa.ubuntu.com/job/libusermetrics-ci/74/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libusermetrics-trusty-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libusermetrics-trusty-armhf-ci/21
        deb: http://jenkins.qa.ubuntu.com/job/libusermetrics-trusty-armhf-ci/21/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/libusermetrics-ci/74/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Pete Woods (pete-woods) wrote :

LGTM

review: Approve
Reply
Revision history for this message
Robert Bruce Park (robru) wrote :

It seems xnox took the opposite approach, blacklisting arches where valgrind is not available:

http://launchpadlibrarian.net/170310103/libusermetrics_1.1.1%2B14.04.20140305-0ubuntu1_1.1.1%2B14.04.20140305-0ubuntu2.diff.gz

Reply
Revision history for this message
Colin Watson (cjwatson) wrote :

Either would technically work, but I think in general positive terminology is better when it's a case of something that has to be explicitly ported to each new architecture; it saves on effort when we introduce new architectures.

Reply
Revision history for this message
Pete Woods (pete-woods) wrote :

The debate doesn't really matter when this is already released / merged. Thankyou for the MR. :)

Reply

Unmerged revisions

150. By Colin Watson

Only require valgrind on architectures where it is available.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: