Merge lp://staging/~cjwatson/lazr.sshserver/more-key-types into lp://staging/lazr.sshserver
Proposed by
Colin Watson
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 78 | ||||
| Proposed branch: | lp://staging/~cjwatson/lazr.sshserver/more-key-types | ||||
| Merge into: | lp://staging/lazr.sshserver | ||||
| Diff against target: |
187 lines (+61/-17) 3 files modified
src/lazr/sshserver/NEWS.txt (+8/-0) src/lazr/sshserver/auth.py (+4/-0) src/lazr/sshserver/tests/test_auth.py (+49/-17) |
||||
| To merge this branch: | bzr merge lp://staging/~cjwatson/lazr.sshserver/more-key-types | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| William Grant (community) | code | Approve | |
|
Review via email:
|
|||
Commit message
Add support-
Description of the change
This also requires a sufficient version of Twisted (which at the time of writing supports ECDSA but not Ed25519) and support in the Launchpad authserver.
I've confirmed this to work locally with a modified version of Launchpad. Before pushing the Launchpad changes, we need to land these lazr.sshserver changes and upgrade its various users, since otherwise it would be rather confusing that you can add ECDSA keys but not authenticate using them.
Adding Ed25519 here is anticipatory, but it's harmless and will save us a step once Twisted gains Ed25519 support.
To post a comment you must log in.
Revision history for this message
| William Grant (wgrant) | # |
review:
Approve
(code)
Revision history for this message
| Colin Watson (cjwatson) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
