Merge lp://staging/~cjwatson/lazr.restfulclient/distro into lp://staging/lazr.restfulclient

Proposed by Colin Watson
Status: Merged
Merged at revision: 155
Proposed branch: lp://staging/~cjwatson/lazr.restfulclient/distro
Merge into: lp://staging/lazr.restfulclient
Prerequisite: lp://staging/~cjwatson/lazr.restfulclient/tox
Diff against target: 245 lines (+50/-90)
4 files modified
setup.py (+5/-1)
src/lazr/restfulclient/authorize/oauth.py (+5/-6)
src/lazr/restfulclient/docs/NEWS.rst (+3/-0)
src/lazr/restfulclient/tests/test_oauth.py (+37/-83)
To merge this branch: bzr merge lp://staging/~cjwatson/lazr.restfulclient/distro
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+344799@code.staging.launchpad.net

Commit message

Use the distro module rather than platform.linux_distribution.

Description of the change

This looks nicer than inlining the relevant bits of code ourselves, which had been my previous plan.

While I was here, I converted the associated tests to fixtures, simplifying them considerably.

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches