Merge lp://staging/~cjwatson/lazr.restfulclient/access-token-compat into lp://staging/lazr.restfulclient

Proposed by Colin Watson
Status: Merged
Merged at revision: 172
Proposed branch: lp://staging/~cjwatson/lazr.restfulclient/access-token-compat
Merge into: lp://staging/lazr.restfulclient
Diff against target: 91 lines (+52/-0)
3 files modified
NEWS.rst (+7/-0)
src/lazr/restfulclient/authorize/oauth.py (+19/-0)
src/lazr/restfulclient/tests/test_oauth.py (+26/-0)
To merge this branch: bzr merge lp://staging/~cjwatson/lazr.restfulclient/access-token-compat
Reviewer Review Type Date Requested Status
Thiago F. Pappacena (community) Approve
LAZR Developers Pending
Review via email: mp+378084@code.staging.launchpad.net

Commit message

Restore some AccessToken methods.

Description of the change

Restore from_string, to_string, and __str__ methods of lazr.restfulclient.authorize.oauth.AccessToken, unintentionally removed in 0.14.0. This caused a test failure when attempting to upgrade Launchpad from 0.13.2 to 0.14.2.

AccessToken.from_string doesn't have particularly clean error handling, but this was true of the previous oauth-based version as well.

The test regression was caused by https://code.launchpad.net/~cjwatson/lazr.restfulclient/oauthlib/+merge/344716.

To post a comment you must log in.
Revision history for this message
Thiago F. Pappacena (pappacena) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches