Merge lp://staging/~cjwatson/lazr.restful/web-service-caller-multipart-named-post into lp://staging/lazr.restful

Proposed by Colin Watson
Status: Merged
Merged at revision: 274
Proposed branch: lp://staging/~cjwatson/lazr.restful/web-service-caller-multipart-named-post
Merge into: lp://staging/lazr.restful
Diff against target: 226 lines (+127/-20)
4 files modified
NEWS.rst (+9/-0)
setup.py (+1/-1)
src/lazr/restful/example/base/tests/hostedfile.txt (+10/-3)
src/lazr/restful/testing/webservice.py (+107/-16)
To merge this branch: bzr merge lp://staging/~cjwatson/lazr.restful/web-service-caller-multipart-named-post
Reviewer Review Type Date Requested Status
Ioana Lasc (community) Approve
Review via email: mp+395705@code.staging.launchpad.net

Commit message

Rework WebServiceCaller to send named POSTs as multipart/form-data.

Description of the change

Arguments that are instances of io.BufferedIOBase are sent as-is rather than being encoded as JSON. This allows robust use of binary arguments on both Python 2 and 3.

To post a comment you must log in.
Revision history for this message
Ioana Lasc (ilasc) wrote :

looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches