lazr.restful

Merge lp://staging/~cjwatson/lazr.restful/url-dereferencing-server-url into lp://staging/lazr.restful

  1. url-dereferencing-server-url
  2. Merge into trunk
Proposed by Colin Watson
Status: Merged
Merged at revision: 255
Proposed branch: lp://staging/~cjwatson/lazr.restful/url-dereferencing-server-url
Merge into: lp://staging/lazr.restful
Diff against target: 91 lines (+33/-1)
4 files modified
NEWS.rst (+5/-0)
src/lazr/restful/docs/webservice-marshallers.rst (+9/-0)
src/lazr/restful/example/base/traversal.py (+16/-1)
src/lazr/restful/marshallers.py (+3/-0)
To merge this branch: bzr merge lp://staging/~cjwatson/lazr.restful/url-dereferencing-server-url
Reviewer Review Type Date Requested Status
Tom Wardill (community) Approve
Review via email: mp+390089@code.staging.launchpad.net

Commit message

Fix dereferencing of URLs that redirect within HTTPS requests.

Description of the change

URLDereferencingMixin.dereference_url didn't necessarily set SERVER_URL, so the request machinery defaulted to http:// URLs. This could cause dereferencing failures depending on the strictness of the IAbsoluteURL adapter being used.

To post a comment you must log in.
Revision history for this message
Tom Wardill (twom) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches