lazr.restful

Merge lp://staging/~cjwatson/lazr.restful/py3-response-wrapper into lp://staging/lazr.restful

  1. py3-response-wrapper
  2. Merge into trunk
Proposed by Colin Watson
Status: Merged
Merged at revision: 270
Proposed branch: lp://staging/~cjwatson/lazr.restful/py3-response-wrapper
Merge into: lp://staging/lazr.restful
Diff against target: 50 lines (+18/-6)
1 file modified
src/lazr/restful/testing/webservice.py (+18/-6)
To merge this branch: bzr merge lp://staging/~cjwatson/lazr.restful/py3-response-wrapper
Reviewer Review Type Date Requested Status
Ioana Lasc (community) Approve
Review via email: mp+390377@code.staging.launchpad.net

Commit message

Fix WebServiceResponseWrapper for Python 3.

Description of the change

The reimplementation of http.client.HTTPMessage using email.message.Message in 3.0 removed the headers attribute, so we need to go to some effort to deal with that.

Sorting list responses in the jsonBody method doesn't make sense, so stop doing that.

To post a comment you must log in.
Revision history for this message
Ioana Lasc (ilasc) wrote :

makes sense to me, looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches