Merge lp://staging/~cjwatson/launchpad/remove-delayed-copies into lp://staging/launchpad
| Status: | Merged | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Approved by: | William Grant | ||||||||||||
| Approved revision: | no longer in the source branch. | ||||||||||||
| Merged at revision: | 16274 | ||||||||||||
| Proposed branch: | lp://staging/~cjwatson/launchpad/remove-delayed-copies | ||||||||||||
| Merge into: | lp://staging/launchpad | ||||||||||||
| Diff against target: |
2008 lines (+131/-1281) 18 files modified
database/schema/comments.sql (+1/-1) lib/lp/archiveuploader/tests/test_sync_notification.py (+1/-2) lib/lp/security.py (+1/-9) lib/lp/soyuz/browser/queue.py (+2/-25) lib/lp/soyuz/configure.zcml (+0/-2) lib/lp/soyuz/doc/closing-bugs-from-changelogs.txt (+0/-22) lib/lp/soyuz/doc/distroseriesqueue.txt (+0/-138) lib/lp/soyuz/interfaces/queue.py (+0/-26) lib/lp/soyuz/model/binarypackagebuild.py (+4/-11) lib/lp/soyuz/model/queue.py (+6/-101) lib/lp/soyuz/model/sourcepackagerelease.py (+3/-5) lib/lp/soyuz/scripts/packagecopier.py (+58/-174) lib/lp/soyuz/scripts/processaccepted.py (+1/-5) lib/lp/soyuz/scripts/tests/test_copypackage.py (+43/-318) lib/lp/soyuz/stories/ppa/xx-ppa-files.txt (+1/-2) lib/lp/soyuz/stories/soyuz/xx-queue-pages-delayed-copies.txt (+0/-133) lib/lp/soyuz/templates/distroseries-queue.pt (+10/-31) lib/lp/soyuz/tests/test_packageupload.py (+0/-276) |
||||||||||||
| To merge this branch: | bzr merge lp://staging/~cjwatson/launchpad/remove-delayed-copies | ||||||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| William Grant | code | Approve | |
|
Review via email:
|
|||
Commit message
Remove delayed copies, now entirely superseded by PackageCopyJobs.
Description of the change
== Summary ==
Delayed copies are elderly, crufty, and the source of multiple critical bugs. Nobody likes them, everybody hates them, and they should just go and eat worms.
== Proposed fix ==
Now that PackageCopyJobs support unembargoing private uploads and all callers have been converted to them, we can delete delayed copies. This does mean that if somebody goes to the effort of looking up old delayed copies in +queue then they'll be rendered under the expander triangle as a list of source files rather than as "Copied from <source archive>" (example: https:/
Note that this must not be landed until r16270 has been deployed to production and we've verified with webops that there are no pending delayed uploads on production.
== Special deployment instructions ==
It is vitally important that, after this change is deployed, we do a little happy dance.
== Tests ==
bin/test -vvct archiveuploader -t soyuz
== Lint ==
One false positive:
./lib/lp/
196: redefinition of function 'copyright' from line 187
| Colin Watson (cjwatson) wrote | # |
| William Grant (wgrant) | # |
r16270 has been deployed and I've verified that the only non-DONE delayed uploads on production are 13 REJECTED ones from over a year ago. The most recent revision on this branch arranges that it's impossible to accept those.