Merge lp://staging/~cjwatson/launchpad/getpublishedbinaries-sorting into lp://staging/launchpad

Proposed by Colin Watson
Status: Merged
Merged at revision: 17425
Proposed branch: lp://staging/~cjwatson/launchpad/getpublishedbinaries-sorting
Merge into: lp://staging/launchpad
Diff against target: 752 lines (+198/-148)
12 files modified
lib/lp/archivepublisher/tests/test_ftparchive.py (+2/-2)
lib/lp/archivepublisher/tests/test_publisher.py (+1/-1)
lib/lp/registry/doc/distroseries.txt (+2/-2)
lib/lp/soyuz/doc/archive.txt (+23/-23)
lib/lp/soyuz/interfaces/archive.py (+23/-4)
lib/lp/soyuz/model/archive.py (+110/-102)
lib/lp/soyuz/scripts/tests/test_initialize_distroseries.py (+3/-3)
lib/lp/soyuz/stories/ppa/xx-ppa-packages.txt (+1/-1)
lib/lp/soyuz/stories/webservice/xx-binary-package-publishing.txt (+1/-1)
lib/lp/soyuz/stories/webservice/xx-source-package-publishing.txt (+1/-1)
lib/lp/soyuz/tests/test_archive.py (+28/-6)
lib/lp/soyuz/tests/test_packagecopyjob.py (+3/-2)
To merge this branch: bzr merge lp://staging/~cjwatson/launchpad/getpublishedbinaries-sorting
Reviewer Review Type Date Requested Status
William Grant code Approve
Review via email: mp+255822@code.staging.launchpad.net

Commit message

Improve performance of Archive.getPublishedSources and Archive.getPublishedBinaries, including adding order_by_date options which provide a reasonable way for applications to catch up with new publications.

Description of the change

Improve performance of Archive.getPublishedSources and Archive.getPublishedBinaries, including adding order_by_date options which provide a reasonable way for applications to catch up with new publications.

It would be nice to insert StormRangeFactory in here too, providing a stable way to slice the returned collection. As explained in the linked bug, though, that is currently difficult, and this is enough to provide a safe API provided that the status filter is omitted (so that entries don't disappear from the collection during iteration).

To post a comment you must log in.
Revision history for this message
William Grant (wgrant) :
review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.