Merge lp://staging/~cjwatson/launchpad/async-copy-unembargo into lp://staging/launchpad
Status: | Merged |
---|---|
Approved by: | Colin Watson |
Approved revision: | no longer in the source branch. |
Merged at revision: | 15664 |
Proposed branch: | lp://staging/~cjwatson/launchpad/async-copy-unembargo |
Merge into: | lp://staging/launchpad |
Diff against target: |
193 lines (+116/-10) 2 files modified
lib/lp/soyuz/browser/archive.py (+1/-1) lib/lp/soyuz/browser/tests/archive-views.txt (+115/-9) |
To merge this branch: | bzr merge lp://staging/~cjwatson/launchpad/async-copy-unembargo |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | code | Approve | |
Review via email:
|
Commit message
Pass the unembargo flag when doing asynchronous copies in the web UI, to match the synchronous path.
Description of the change
== Summary ==
Bug 1026976: Asynchronous copies via the web UI (available to beta testers) create a PCJ which oopses when trying to copy from a private archive to a public archive.
== Proposed fix ==
Add the unembargo=True flag. I meant to do this a while back, actually, but I had it in a future cleanup branch so forgot about it.
== Pre-implementation notes ==
Cody Somerville raised a concern that there needs to be some kind of confirmation step here. While I think this would be reasonable, the synchronous copy path (which is still used for everyone who isn't in launchpad-
== LOC Rationale ==
+106. This will be comfortably more than offset by removing the synchronous copy path once the asynchronous path has passed its beta testing phase.
== Tests ==
bin/test -vvct archive-views.txt
== Demo and Q/A ==
Upload a package to a private archive on dogfood. Make sure you're in ~launchpad-
This change looks good Colin.