Merge lp://staging/~cjwatson/launchpad-buildd/snap-non-root into lp://staging/launchpad-buildd
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Merged at revision: | 227 |
| Proposed branch: | lp://staging/~cjwatson/launchpad-buildd/snap-non-root |
| Merge into: | lp://staging/launchpad-buildd |
| Diff against target: |
93 lines (+30/-4) (has conflicts) 2 files modified
buildsnap (+20/-4) debian/changelog (+10/-0) Text conflict in debian/changelog |
| To merge this branch: | bzr merge lp://staging/~cjwatson/launchpad-buildd/snap-non-root |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| William Grant (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Run snapcraft as non-root with passwordless sudo, since we run into
buggy corner cases in some plugins when running as root (LP: #1702656).
Description of the change
This will need a fair bit of QA with various snaps to make sure we aren't introducing a different set of corner cases instead.
This introduces a dependency on the buildd user existing in the chroot, which is true but I'm not sure was previously explicitly required anywhere. If it isn't OK to rely on this then I can add code to ensure that it's true.
To post a comment you must log in.
Revision history for this message
| Colin Watson (cjwatson) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks fine, though as discussed on IRC I don't see how buildd inside the chroot manages to get passwordless sudo -- NOPASSWD for %sudo hasn't been the default since 2009.